Add model validation on model_copy to ConfigBaseModel#118
Open
Add model validation on model_copy to ConfigBaseModel#118
Conversation
cfs-data
changed the title
cfs-data
changed the title
cfs-data
changed the title
cfs-data
changed the title
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
|
Minimum allowed line rate is |
Raytesnel
approved these changes
Feb 5, 2026
Collaborator
Raytesnel
left a comment
Raytesnel
left a comment
There was a problem hiding this comment.
I think model_copy will not be used after all the upcoming changes of the ImageMutation. but more validations are always welcome :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: in many places we use
model_copy(update=...)which does not trigger validation routines.Solution: Override the method in base class so that
pydanticmodels are validated even when usingmodel_copy.This triggered two exceptions in unit tests:
_centerin aMarkinstance (which has been renamed tocenter_). This has been fixed by simply renaming the keywordnumpyfor trying to coerce atupletonumpy.floating. This has been fixed by making the target datatype explicit:numpy.float64